Provide functions to terminate the TBB thread pool in library interfaces #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems the TBB version in the CI doesn't have |
I think this is the only option. At least the MacOS CI build has the newest version. We should also replace the Ubuntu 20 build with an Ubuntu 24 CI build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to terminate the TBB thread pool via interface functions in the C and Python interface (resolves issue #187).
Note the change uses
oneapi::tbb::task_scheduler_handlewhich is fully functional since oneTBB 2021.6. It seems that our CI uses oneTBB 2021.5 which needs to be fixed before merging.